Yarn Upgrade #33
Merged
Yarn Upgrade #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fleupold
commented
Jan 2, 2025
| @@ -1351,11 +1307,6 @@ proxy-from-env@^1.1.0: | |||
| resolved "https://registry.yarnpkg.com/proxy-from-env/-/proxy-from-env-1.1.0.tgz#e102f16ca355424865755d2c9e8ea4f24d58c3e2" | |||
| integrity sha512-D+zkORCbA9f1tdWRK0RaCR3GPv50cMxcrz4X8k5LTSUD1Dkw47mKJEZQNunItRTkWwgtaUSo1RVFRIG9ZXiFYg== | |||
|
|
|||
| punycode@^2.1.0: | |||
fedgiac
approved these changes
Jan 3, 2025
Merged
fleupold
added a commit
that referenced
this pull request
Jan 8, 2025
After #33, the existing code would generate a newer version of the app data ``` {"appCode":"CoWFeeModule","environment":"prod","metadata":{},"version":"1.3.0"} vs {"appCode":"CoWFeeModule","environment":"prod","metadata":{},"version":"1.1.0"} ``` which consequently led to [this error](https://github.com/cowdao-grants/cow-fee/blob/main/ts/cowfee.ts#L172) being hit. @alfetopito suggested to manually generate the app data, given that it's hardcoded and fixed in the fee withdrawl module ## Other changes I had to change the target of the tsconfig to es2022 because es2023 is not supported by my node version (lts, v22.13.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting deprecation warnings with the latest version of node:
yarn upgradeupdates all dependencies and gets rid of the punycode dependency.