Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code signing chapter #1597

Merged
merged 1 commit into from
Jan 22, 2024
Merged

update code signing chapter #1597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions Documentation/ReleasePlan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,15 @@ This is the steps to release new packages to nuget.org
Successfully created package 'D:\git\coverlet\bin\Release\Packages\coverlet.console.6.0.1-preview.6.g918cd179e0.snupkg'.
```

4. Sign the packages using SignClient tool <https://www.nuget.org/packages/SignClient>

```powershell
❯ SignClient "Sign" `
>> --baseDirectory "REPO ROOT DIRECTORY\bin" `
>> --input "**/*.nupkg" `
>> --config "ROOT REPO DIRECTORY\eng\signclient.json" `
>> --user "USER" `
>> --secret "SECRET" `
>> --name "Coverlet" `
>> --description "Coverlet" `
>> --descriptionUrl "https://github.com/coverlet-coverage/coverlet"
4. Sign the packages using NuGetKeyVaultSignTool <https://www.nuget.org/packages/NuGetKeyVaultSignTool>

```
❯ NuGetKeyVaultSignTool sign **/*.nupkg --file-digest sha256 --timestamp-rfc3161 http://timestamp.digicert.com --timestamp-digest sha256 `
>> --azure-key-vault-url KEYVAULT-URL `
>> --azure-key-vault-client-id CLIENT-ID `
>> --azure-key-vault-tenant-id TENANT-ID `
>> --azure-key-vault-client-secret KEYVAULT-SECRET `
>> --azure-key-vault-certificate CERT-FRIENDLY-NAME
```

5. Upload *.nupkg files to Nuget.org site. **Check all metadata(url links, deterministic build etc...) before "Submit"**
Expand Down