feat(SFINT-5848): Playwright migration for QuanticBreadcrumbManager tests #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
SimonMilord
reviewed
Jan 7, 2025
packages/quantic/force-app/main/default/lwc/quanticBreadcrumbManager/e2e/pageObject.ts
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jan 7, 2025
packages/quantic/force-app/main/default/lwc/quanticBreadcrumbManager/e2e/pageObject.ts
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jan 7, 2025
...ntic/force-app/main/default/lwc/quanticBreadcrumbManager/e2e/quanticBreadcrumbManager.e2e.ts
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jan 7, 2025
...ntic/force-app/main/default/lwc/quanticBreadcrumbManager/e2e/quanticBreadcrumbManager.e2e.ts
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jan 7, 2025
...rce-app/main/default/lwc/quanticBreadcrumbManager/__tests__/quanticBreadcrumbManager.test.js
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jan 7, 2025
...rce-app/main/default/lwc/quanticBreadcrumbManager/__tests__/quanticBreadcrumbManager.test.js
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jan 7, 2025
...rce-app/main/default/lwc/quanticBreadcrumbManager/__tests__/quanticBreadcrumbManager.test.js
Show resolved
Hide resolved
SimonMilord
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-5848
We're now at 72 tests for Playwright, they run on my machine in 38.3s 🚀
I also moved a bunch of the Cypress tests we had for the QuanticBreadcrumbManager to unit tests. They mainly concerned the way we "hide" breadcrumb values when they go over a threshold behind a "Show more" button (no reason to test this via e2e as it's not even tied to the size of the container, just a threshold value)
Same thing for the tests around different options such as a custom value for the Show more threshold, and a custom delimiter for the Category facets.
Other than that I added plenty of tests for each type of facets to make sure the analytics Search event contains the correct format for the value that was de-selected using the breadcrumb X.