feat(snapshot): add --snapshotId flag to push and preview commands
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Louis Bompart <lbompart@coveo.com>
Co-authored-by: Louis Bompart <lbompart@coveo.com>
olamothe
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/CDX-514
Proposed changes
Pushing or previewing a large snapshot leads to a timeout with no possible action.
The idea is to add a
--snapshotIdto bothorg:config:pushandorg:config:previewcommands in case the manipulated snapshot leads to aSnapshotOperationTimeoutErrorerror.If that is the case, the user will still be able to preview or push his snapshot once idle.
Testing
SnapshotOperationTimeoutErrorerrorCDX-514