Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): wait for snapshot to be done #378

Merged
merged 3 commits into from
Jul 26, 2021
Merged

fix(cli): wait for snapshot to be done #378

merged 3 commits into from
Jul 26, 2021

Conversation

y-lakhdar
Copy link
Contributor

https://coveord.atlassian.net/browse/CDX-503

Proposed changes

Pulling a snapshot by its ID will cause an error since the command tries to download the snapshot in a pending state.
The fix is simply to add a waitUntilDone promise to make sure the snapshot is idle before manipulating it.

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:
  1. Create a big snapshot.
  2. Pull the snapshot while it is still pending.
  3. It will show a spinner animation instead of breaking

CDX-503

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@y-lakhdar y-lakhdar merged commit 9eb81a2 into master Jul 26, 2021
@louis-bompart louis-bompart deleted the CDX-503 branch July 29, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants