Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to support delete changes #258

Merged
merged 117 commits into from
Jun 17, 2021
Merged

feat: add flag to support delete changes #258

merged 117 commits into from
Jun 17, 2021

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Jun 11, 2021

Proposed changes

Add a flag to show missing resources. By default the Snapshot API will not delete missing resources in the target org unless specified. Similarly, the preview command in the CLI will not show resources to delete unless the user specifically adds the flag to the command.

Example

Without the flag
image

With the flag
image

Notes: I also adde

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

CDX-361

y-lakhdar added 30 commits May 28, 2021 08:36
@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

packages/cli/src/lib/snapshot/reportViewer.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/snapshot/reportViewer.ts Outdated Show resolved Hide resolved
@olamothe olamothe mentioned this pull request Jun 14, 2021
3 tasks
@y-lakhdar y-lakhdar changed the base branch from CDX-346 to CDX-387 June 15, 2021 15:59
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oli idea for the refactor, other than that lgtm!

@y-lakhdar y-lakhdar changed the base branch from CDX-387 to master June 15, 2021 16:44
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there something to be made here :)

packages/cli/src/lib/snapshot/reportViewer.ts Outdated Show resolved Hide resolved
@y-lakhdar y-lakhdar mentioned this pull request Jun 16, 2021
3 tasks
@y-lakhdar y-lakhdar requested a review from louis-bompart June 17, 2021 12:38
@y-lakhdar y-lakhdar merged commit e0c9aad into master Jun 17, 2021
@louis-bompart louis-bompart deleted the CDX-361 branch July 29, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants