feat(cli): display "Happy Hacking" message at the end of the project creation #178
Conversation
y-lakhdar
commented
Apr 22, 2021
- Making sure the "Happy Hacking" message is displayed at the complete end of the project creation
- Added a spinner for the token server creation. Otherwise there's a couple of seconds without any feedback
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
| @@ -16,6 +17,7 @@ import { | |||
| IsNpxInstalled, | |||
| } from '../../../lib/decorators/preconditions'; | |||
| import {appendCmdIfWindows} from '../../../lib/utils/os'; | |||
| import {EOL} from 'os'; | |||
There was a problem hiding this comment.
- Test on Windows. (I'll do it)
There was a problem hiding this comment.
Can you try the buffer? I'm curious ;)
Also, I think we could improve the E2E for react in that sense to detect the 'Happy HAcking!' as a exit signal, as we did for the others.
Apart from that great job!
Tho, PSA y'all:
We should build and test the binary.
|
|
||
| const args = this.args; | ||
| let stopWritingInTerminal = false; | ||
| let remainingString = ''; |
There was a problem hiding this comment.
I think that if you create a buffer and write in it, it might works without --color=always and be more efficient :)
There was a problem hiding this comment.
oups. The --color-always was added as an initial tentative to preserve the colors. Now that we use node-pty, I don't need it.
| name: 'xterm-color', | ||
| cols: process.stdout.columns, | ||
| rows: process.stdout.rows, | ||
| cwd: options.cwd || process.cwd(), |
There was a problem hiding this comment.
Use ?? instead of ||. cwd:'' is valid IMO
Co-authored-by: Louis Bompart <lbompart@coveo.com>
|
Looks like it broke the E2E tests.
|
Just to be clear about the |
|
I'm building binaries from this branch to ensures all's well: |
|
The behaviour constated:
Expected behaviour:
|
|
When using a valid process name, the terminal/stdin is not released :/ |
* use winpty always + catch err https://coveord.atlassian.net/browse/CDX-255 * destruc https://coveord.atlassian.net/browse/CDX-225