Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchSizeFinder now handles weird KeyError #257

Merged
merged 1 commit into from
Feb 13, 2024
Merged

BatchSizeFinder now handles weird KeyError #257

merged 1 commit into from
Feb 13, 2024

Conversation

MaximilienLC
Copy link
Collaborator

@MaximilienLC MaximilienLC commented Feb 13, 2024

Error was reported in: Lightning-AI/pytorch-lightning#18114 but not reproduced hence not fixed.

Replaces the Tuner with a BatchSizeFinder callback (usually one layer deeper) to retrieve the "optimal" batch size regardless of whether the KeyError occurs.

++ small update to pyproject.toml w/ latest ruff

@MaximilienLC MaximilienLC merged commit bfbcf96 into main Feb 13, 2024
2 checks passed
@MaximilienLC MaximilienLC deleted the bsf-fixer branch February 13, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant