Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommended fix for the documentation #246

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Recommended fix for the documentation #246

merged 6 commits into from
Feb 12, 2024

Conversation

complexbrains
Copy link
Collaborator

This PR adds:

  • Recommendation for adding a timezone flag to set the timezone of the Docker, Podman, and Apptainer containers to the local/preferred timezone.
  • Adds a warning for Maestral's lag in the first initialization in Slurms.

complexbrains and others added 5 commits February 8, 2024 21:36
@complexbrains
Add the container timezone flag
ce80c52 
This commit adds a timezone flag note for Apptainer
@complexbrains
Add the container timezone flag
bd3b96d 
This commit adds a timezone flag note to Docker and Podman.
@complexbrains
Add warning for Maestral initialization
4fdfd73 
Add warning that runing Maestral to start takes a few trials.
@complexbrains
Fix white trailing error in docs
780ffb7
@complexbrains
Fix Contribution trailing white space error
99c0479
MaximilienLC
MaximilienLC approved these changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator

@MaximilienLC MaximilienLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz create an issue to propose the change for apptainer & docker, feels a little wonky to only suggest for podman

@complexbrains
Copy link
Collaborator Author

#248 There you go!

@complexbrains complexbrains merged commit b5d57d8 into main Feb 12, 2024
2 checks passed
@MaximilienLC MaximilienLC deleted the doc_fix_latest branch February 24, 2024 01:06
@MaximilienLC MaximilienLC mentioned this pull request Sep 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximilienLC MaximilienLC MaximilienLC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@complexbrains @MaximilienLC