fix: correct the attribute for the Twitter social image #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b045ee6 to
5ed204f
Compare
5ed204f to
0bff6ea
Compare
|
I'm going to migrate this PR to a hotfix branch. |
cotes2020
pushed a commit
that referenced
this pull request
Mar 22, 2024
kimbob13
pushed a commit
to kimbob13/kimbob13.github.io
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Problem: I have noticed that social image preview is not always being displayed for Twitter and people reporting the same in #1599.
Solution: Follow Twitter guidelines for
metatags naming when we replace generated one by Jekyll.Additional context
I'm using extension to test these changes, but I assume the solution was tested in #1599.