feat: add confix vanity url #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Jan 10, 2023
| <div class="content"> | ||
| <h2>cosmossdk.io/tools/confix</h2> | ||
| <code>go get cosmossdk.io/tools/confix</code> | ||
| <code>import "cosmossdk.io/tools/confix"</code> |
There was a problem hiding this comment.
could we see if we could remove tools here?to experiment
There was a problem hiding this comment.
Yeah, that's a good opportunity!
There was a problem hiding this comment.
Create a new "package" which hardcode the path to /tools so it is still called confix.
I think it may work.
There was a problem hiding this comment.
Well that did not work:
julien:cosmos-sdk/ (julien/config-fix-2 {5}) $ go install cosmossdk.io/confix/cmd/confix@latest
go: cosmossdk.io/confix/cmd/confix@latest: no matching versions for query "latest"
julien:cosmos-sdk/ (julien/config-fix-2 {5}) $ go install cosmossdk.io/tools/confix/cmd/confix@latest
go: downloading cosmossdk.io/tools/confix v0.0.0-20230110102841-9742029158ad
go: cosmossdk.io/tools/confix/cmd/confix@latest (in cosmossdk.io/tools/confix@v0.0.0-20230110102841-9742029158ad):
The go.mod file for the module providing named packages contains one or
more replace directives. It must not contain directives that would cause
it to be interpreted differently than if it were the main module.The second one with the correct url worked. (It didn't install but this message was expected).
|
Merging for trying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after cosmos/cosmos-sdk#14342