Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear code due to unnecessary err value return in FindLedgerCosmosUserApp #50

Closed
odeke-em opened this issue Oct 16, 2023 · 0 comments · Fixed by #57
Closed

Unclear code due to unnecessary err value return in FindLedgerCosmosUserApp #50

odeke-em opened this issue Oct 16, 2023 · 0 comments · Fixed by #57

Comments

@odeke-em
Copy link
Contributor

This code

ledger-cosmos-go/user_app.go

Line 69 in e9d4c19

return app, err

by this point has a nil error and just confuses the reader who might be thinking that err was set from above but really it is nil. That return should be turned into return app, nil

/cc @elias-orijtech @julienrbrt
odeke-em added a commit to orijtech/ledger-cosmos-go that referenced this issue Oct 26, 2023
@odeke-em
fix: improve UX by sending major version info
dc6d6fd 
This change improves user experience (UX) by sending
over the major version information. While here, also
fixed up an unclear return.

Fixes cosmos#50
Fixes cosmos#51
@odeke-em odeke-em mentioned this issue Oct 26, 2023
Merged
ftheirs pushed a commit that referenced this issue Oct 30, 2023
@odeke-em
fix: improve UX by sending major version info (#57)
a4f5d04 
This change improves user experience (UX) by sending over the major
version information. While here, also fixed up an unclear return.

Fixes #50
Fixes #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve UX by sending major version info orijtech/ledger-cosmos-go
1 participant
@odeke-em