Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR: equivocation gov proposal #711

Merged
merged 2 commits into from
Feb 9, 2023
Merged

ADR: equivocation gov proposal #711

merged 2 commits into from
Feb 9, 2023

Conversation

tbruyelle
Copy link
Contributor

Description

Adds a new ADR related to the addition of the equivocation gov proposal, and the disabling of the consumer initiated slashing.

Since the PR that implements the new gov proposal is merged, I considered the status of this ADR accepted.

Type of change

  • Docs: Adds documentation

@albttx albttx mentioned this pull request Feb 6, 2023
Closed
1 task
@shaspitz
Copy link
Contributor

shaspitz commented Feb 6, 2023

Thanks for the contribution! Could you change the relevant ADR number instances from 2 -> 3, as I've just opened this PR for a feature that was merged a couple months ago. Probably best to keep things in the order they were merged

@tbruyelle tbruyelle changed the title adr: equivocation gov proposal ADR: equivocation gov proposal Feb 6, 2023
@tbruyelle @albttx
adr: equivocation gov proposal
01d98d7 
Adds a new ADR related to the addition of the equivocation gov
proposal, and the disabling of the consumer initiated slashing.

Co-authored-by: Albert Le Batteux <contact@albttx.tech>
@tbruyelle
Copy link
Contributor Author

Thanks for the contribution! Could you change the relevant ADR number instances from 2 -> 3, as I've just opened this PR for a feature that was merged a couple months ago. Probably best to keep things in the order they were merged

Done!

shaspitz
shaspitz approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

MSalopek
MSalopek approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC we can inspect IBC releated events on the provider to confirm that an equivocation slash packet was accepted by the provider. The packet is dropped, but the event about it being received will remain.

jtremback
jtremback approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtremback jtremback merged commit 36ff4e5 into cosmos:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtremback jtremback jtremback approved these changes

@MSalopek MSalopek MSalopek approved these changes

@shaspitz shaspitz shaspitz approved these changes

@mpoke mpoke Awaiting requested review from mpoke

@sainoe sainoe Awaiting requested review from sainoe

@mmulji-ic mmulji-ic Awaiting requested review from mmulji-ic

@glnro glnro Awaiting requested review from glnro

@yaruwangway yaruwangway Awaiting requested review from yaruwangway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbruyelle @shaspitz @jtremback @MSalopek