fix: fix signer in the commission rate message

[insumity]

Description

Issuing a MsgSetConsumerCommissionRate message was giving us back:

gaiad tx provider set-consumer-commission-rate pion-1 0.15 --from apple --gas auto --gas-adjustment 2 --gas-prices 0.005uatom -y
Error: rpc error: code = Unknown desc = rpc error: code = Unknown desc = no cosmos.msg.v1.signer option found for message interchain_security.ccv.provider.v1.MsgSetConsumerCommissionRate;

We added the signer but we still received that the address is missing.

This PR fixes this issue by setting the Signer field in the message. After this PR changes, when we issue a
MsgSetConsumerCommissionRate against a local gaiad node we get:

failed to execute message; message index: 0: unknown consumer chain, with id: chain-1: no consumer chain with this chain id'

which means the message got parsed correctly and was about to be handled.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• Included the correct type prefix in the PR title
• Added ! to the type prefix if the change is state-machine breaking
• Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
• Targeted the correct branch (see PR Targeting)
• Provided a link to the relevant issue or specification
• Followed the guidelines for building SDK modules
• Included the necessary unit and integration tests
• Added a changelog entry to CHANGELOG.md
• Included comments for documenting Go code
• Updated the relevant documentation or specification
• Reviewed "Files changed" and left comments if necessary
• Confirmed all CI checks have passed
• If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! the type prefix if the change is state-machine breaking
• confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage

Summary by CodeRabbit

• New Features

  • Enhanced transaction validation by including a signer address in the consumer commission rate message creation.

• Bug Fixes

  • Minor structural adjustment to the message definition for improved clarity, with no impact on functionality.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve minor structural adjustments to the MsgSetConsumerCommissionRate message and enhancements to the relevant command creation functions. The primary modification is the addition of a signer parameter, which improves transaction validation by associating a signer with the commission rate message. Overall, these updates enhance the functionality without altering the underlying logic of the protocol.

Changes

Files	Change Summary
proto/interchain_security/ccv/provider/v1/tx.proto, x/ccv/provider/client/cli/tx.go, x/ccv/provider/types/msg.go	Structural change to MsgSetConsumerCommissionRate by removing a line break; added signer parameter to NewSetConsumerCommissionRateCmd and NewMsgSetConsumerCommissionRate for improved transaction validation.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant MessageService

    User->>CLI: NewSetConsumerCommissionRateCmd(signer)
    CLI->>MessageService: Create MsgSetConsumerCommissionRate(chainID, commission, providerValidatorAddress, signer)
    MessageService-->>CLI: MsgSetConsumerCommissionRate
    CLI-->>User: Transaction ready for signing

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.