Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure VSCMature packets are sent even if no ValidatorUpdates are received #106

Closed
danwt opened this issue May 19, 2022 · 0 comments
Closed

Ensure VSCMature packets are sent even if no ValidatorUpdates are received #106

danwt opened this issue May 19, 2022 · 0 comments
Assignees
@danwt
Labels
type: bug Issues that need priority attention -- something isn't working

Comments

@danwt
Copy link
Contributor

danwt commented May 19, 2022 •
edited
Loading

In the spec at a6bc8d1 it is possible for Maturity packets to never be sent. If the early return is taken here

  if pendingChanges.IsEmpty() {
    // do nothing
    return []
  }
 ..
  if providerChannel != "" {
    UnbondMaturePackets()
  }

we need to make sure this doesn't happen in the implementation.

Relevant issue in spec:
@danwt danwt added type: bug Issues that need priority attention -- something isn't working ccv-core labels May 19, 2022
@danwt danwt moved this to Todo in Replicated Security May 19, 2022
@mpoke mpoke added the mvcc label Jun 8, 2022
@danwt danwt mentioned this issue Jun 10, 2022
Merged
@danwt danwt moved this from Todo to Waiting for review in Replicated Security Jun 10, 2022
@danwt danwt closed this as completed Jun 16, 2022
Repository owner moved this from Waiting for review to Done in Replicated Security Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danwt danwt

Labels
type: bug Issues that need priority attention -- something isn't working
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpoke @danwt