ICS28: vsc will not mature if there are no updates from provider

[danwt]

a6bc8d1

It seems that if the early return is taken in consumer::EndBlock

  if pendingChanges.IsEmpty() {
    // do nothing
    return []
  }
 ..
  if providerChannel != "" {
    UnbondMaturePackets()
  }

then the UnbondMaturePackets will never be called. If there are no changes for many blocks, the provider will never receive the maturity.

ibc/spec/app/ics-028-cross-chain-validation/technical_specification.md

Lines 1723 to 1751 in a6bc8d1

	// CCF: Consumer Chain Function
	// implements the AppModule interface
	function EndBlock(): [ValidatorUpdate] {
	if getCurrentHeight() - lastDistributionTransferHeight >= BlocksPerDistributionTransfer {
	DistributeRewards()
	}
	if pendingChanges.IsEmpty() {
	// do nothing
	return []
	}
	// aggregate the pending changes
	changes = pendingChanges.Aggregate()
	// Note: in the implementation, the aggregation is done directly
	// when receiving a VSCPacket via the AccumulateChanges method.
	// remove all pending changes
	pendingChanges.RemoveAll()
	// update validatorSet
	UpdateValidatorSet(changes)
	// unbond mature packets if the CCV channel is established
	if providerChannel != "" {
	UnbondMaturePackets()
	}
	// return the validator set updates to the consensus engine
	return changes

[danwt]

There's a good chance I've made a mistake in my understanding here, if so, please feel free to close the issue :)

[mpoke]

@danwt Nice catch. Could you please open an issue also on the implementation side?