-
Notifications
You must be signed in to change notification settings - Fork 150
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: move provider hooks tests to integration tests (#1816)
tests: add provider gov hooks integration tests
- Loading branch information
Showing
5 changed files
with
168 additions
and
139 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,149 @@ | ||
| package integration | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "cosmossdk.io/math" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" | ||
| banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" | ||
| v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1" | ||
| "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1" | ||
|
|
||
| testkeeper "github.com/cosmos/interchain-security/v5/testutil/keeper" | ||
| ) | ||
|
|
||
| // tests AfterProposalSubmission and AfterProposalVotingPeriodEnded hooks | ||
| // hooks require adding a proposal in the gov module and regitering a consumer chain with the provider module | ||
| func (s *CCVTestSuite) TestAfterPropSubmissionAndVotingPeriodEnded() { | ||
| ctx := s.providerChain.GetContext() | ||
| providerKeeper := s.providerApp.GetProviderKeeper() | ||
| govKeeper := s.providerApp.GetTestGovKeeper() | ||
| proposer := s.providerChain.SenderAccount | ||
|
|
||
| content := testkeeper.GetTestConsumerAdditionProp() | ||
| content.ChainId = "newchain-0" | ||
| legacyPropContent, err := v1.NewLegacyContent( | ||
| content, | ||
| authtypes.NewModuleAddress("gov").String(), | ||
| ) | ||
| s.Require().NoError(err) | ||
|
|
||
| proposal, err := v1.NewProposal([]sdk.Msg{legacyPropContent}, 1, time.Now(), time.Now().Add(1*time.Hour), "metadata", "title", "summary", proposer.GetAddress(), false) | ||
| s.Require().NoError(err) | ||
|
|
||
| err = govKeeper.SetProposal(ctx, proposal) | ||
| s.Require().NoError(err) | ||
|
|
||
| providerKeeper.Hooks().AfterProposalSubmission(ctx, proposal.Id) | ||
|
|
||
| // verify that the proposal ID is created | ||
| proposalIdOnProvider := providerKeeper.GetProposedConsumerChain(ctx, proposal.Id) | ||
| s.Require().NotEmpty(proposalIdOnProvider) | ||
| s.Require().Equal(content.ChainId, proposalIdOnProvider) | ||
|
|
||
| providerKeeper.Hooks().AfterProposalVotingPeriodEnded(ctx, proposal.Id) | ||
| // verify that the proposal ID is deleted | ||
| s.Require().Empty(providerKeeper.GetProposedConsumerChain(ctx, proposal.Id)) | ||
| } | ||
|
|
||
| func (s *CCVTestSuite) TestGetConsumerAdditionLegacyPropFromProp() { | ||
| ctx := s.providerChain.GetContext() | ||
| proposer := s.providerChain.SenderAccount | ||
|
|
||
| // create a dummy bank send message | ||
| dummyMsg := &banktypes.MsgSend{ | ||
| FromAddress: sdk.AccAddress(proposer.GetAddress()).String(), | ||
| ToAddress: sdk.AccAddress(proposer.GetAddress()).String(), | ||
| Amount: sdk.NewCoins(sdk.NewCoin("stake", math.OneInt())), | ||
| } | ||
|
|
||
| textProp, err := v1.NewLegacyContent( | ||
| v1beta1.NewTextProposal("a title", "a legacy text prop"), | ||
| authtypes.NewModuleAddress("gov").String(), | ||
| ) | ||
| s.Require().NoError(err) | ||
|
|
||
| addConsumerProp, err := v1.NewLegacyContent( | ||
| testkeeper.GetTestConsumerAdditionProp(), | ||
| authtypes.NewModuleAddress("gov").String(), | ||
| ) | ||
| s.Require().NoError(err) | ||
|
|
||
| testCases := []struct { | ||
| name string | ||
| propMsg sdk.Msg | ||
| expectConsumerPropFound bool | ||
| expPanic bool | ||
| }{ | ||
| { | ||
| name: "prop not found", | ||
| propMsg: nil, | ||
| expectConsumerPropFound: false, | ||
| expPanic: false, | ||
| }, | ||
| { | ||
| name: "msgs in prop contain no legacy props", | ||
| propMsg: dummyMsg, | ||
| expectConsumerPropFound: false, | ||
| expPanic: false, | ||
| }, | ||
| { | ||
| name: "msgs contain a legacy prop but not of ConsumerAdditionProposal type", | ||
| propMsg: textProp, | ||
| expectConsumerPropFound: false, | ||
| }, | ||
| { | ||
| name: "msgs contain an invalid legacy prop", | ||
| propMsg: &v1.MsgExecLegacyContent{}, | ||
| expectConsumerPropFound: false, | ||
| expPanic: true, | ||
| }, | ||
| { | ||
| name: "msg contains a prop of ConsumerAdditionProposal type - hook should create a new proposed chain", | ||
| propMsg: addConsumerProp, | ||
| expectConsumerPropFound: true, | ||
| expPanic: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| s.Run(tc.name, func() { | ||
| providerKeeper := s.providerApp.GetProviderKeeper() | ||
| govKeeper := s.providerApp.GetTestGovKeeper() | ||
|
|
||
| var proposal v1.Proposal | ||
| var err error | ||
|
|
||
| if tc.propMsg == nil { | ||
| // cover edgecase where proposal has no messages | ||
| proposal, err = v1.NewProposal([]sdk.Msg{}, 1, time.Now(), time.Now().Add(1*time.Hour), "metadata", "title", "summary", proposer.GetAddress(), false) | ||
| s.Require().NoError(err) | ||
| } else { | ||
| // cover variolus cases where proposal has messages but only some are consumer addition proposals | ||
| proposal, err = v1.NewProposal([]sdk.Msg{tc.propMsg}, 1, time.Now(), time.Now().Add(1*time.Hour), "metadata", "title", "summary", proposer.GetAddress(), false) | ||
| s.Require().NoError(err) | ||
| } | ||
|
|
||
| err = govKeeper.SetProposal(ctx, proposal) | ||
| s.Require().NoError(err) | ||
|
|
||
| if tc.expPanic { | ||
| s.Require().Panics(func() { | ||
| // this panics with a nil pointer dereference because the proposal is invalid and cannot be unmarshalled | ||
| providerKeeper.Hooks().GetConsumerAdditionLegacyPropFromProp(ctx, proposal.Id) | ||
| }) | ||
| return | ||
| } | ||
|
|
||
| savedProp, found := providerKeeper.Hooks().GetConsumerAdditionLegacyPropFromProp(ctx, proposal.Id) | ||
| if tc.expectConsumerPropFound { | ||
| s.Require().True(found) | ||
| s.Require().NotEmpty(savedProp, savedProp) | ||
| } else { | ||
| s.Require().False(found) | ||
| s.Require().Empty(savedProp) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters