chore(rust): update prost to v0.12
#202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prost to v0.12prost to v0.12
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
===========================================
+ Coverage 48.72% 65.36% +16.63%
===========================================
Files 23 7 -16
Lines 9920 3560 -6360
Branches 86 0 -86
===========================================
- Hits 4834 2327 -2507
+ Misses 4725 1233 -3492
+ Partials 361 0 -361
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
romac
commented
Sep 29, 2023
| @@ -8,6 +8,6 @@ edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| bytes = "1.0.1" | |||
| prost = "0.11" | |||
| prost = "0.12" | |||
| prost-build = "0.12" | |||
There was a problem hiding this comment.
For some reason, prost-build was already on v0.12.
hdevalence
approved these changes
Sep 29, 2023
|
This counts as an API-breaking change for the Rust code, right? What's the policy about crate versioning vs. ICS versioning? If we have a change to the Rust crate that's API-breaking but not different at the protocol level, how is that handled? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.