Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retract previous versions #131

Merged
merged 1 commit into from
Jan 3, 2023
Merged

chore: retract previous versions #131

merged 1 commit into from
Jan 3, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 19, 2022

Closes #125

This will be enforced at next ICS23 tag.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 39.35% // Head: 38.11% // Decreases project coverage by -1.24% ⚠️

Coverage data is based on head (4880e74) compared to base (9919ce9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   39.35%   38.11%   -1.25%     
==========================================
  Files          16        5      -11     
  Lines        6286     4182    -2104     
  Branches       85        0      -85     
==========================================
- Hits         2474     1594     -880     
+ Misses       3456     2275    -1181     
+ Partials      356      313      -43     
Flag Coverage Δ
go 38.11% <ø> (ø)
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/src/specs.ts
js/src/proofs.ts
js/src/generated/codecimpl.js
js/src/ics23.ts
js/src/compress.ts
js/src/testvectors.spec.ts
js/src/ops.ts
js/src/ops.spec.ts
js/src/testhelpers.spec.ts
js/jasmine-testrunner.js
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julienrbrt julienrbrt requested a review from tac0turtle January 2, 2023 21:52
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should see if this is breaking for ibc versions

@julienrbrt
Copy link
Member Author

We should see if this is breaking for ibc versions

I don't think it's breaking as retracting a version does not prohibit it to be downloaded if already imported by a package.

@tac0turtle tac0turtle merged commit f4deb05 into master Jan 3, 2023
@tac0turtle tac0turtle deleted the julien/go-retract branch January 3, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retract ics23 0.7
2 participants