ICS27 Port Changes #641
Merged
ICS27 Port Changes #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
commented
Jan 20, 2022
| // checks to make sure the account has not already been registered | ||
| // creates a new address on chain | ||
| // creates a new address on chain deterministically given counterpartyPortId and underlying connectionID |
There was a problem hiding this comment.
Ref: cosmos/ibc-go#767
There was a problem hiding this comment.
Is it worth mentioning that it's the host side connection-id?
seantking
approved these changes
Jan 20, 2022
colin-axner
approved these changes
Jan 20, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to PortID from #638
Only includes removing connectionIDs from the portID and updating relevant APIs.
To ensure correctness, this also includes the recommended change in cosmos/ibc-go#767