Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a newtype wrapper for the timestamp #83

Closed
5 tasks done
adizere opened this issue Mar 22, 2021 · 1 comment
Closed
5 tasks done

Introduce a newtype wrapper for the timestamp #83

adizere opened this issue Mar 22, 2021 · 1 comment
Assignees
@soareschen
Labels
A: good-first-issue Admin: good for newcomers O: new-feature Objective: aims to add new feature

Comments

@adizere
Copy link
Contributor

adizere commented Mar 22, 2021

Crate

ibc

Summary

We could introduce a newtype wrapper for the timestamp, here and in other places where we currently use a u64, eg. a pub struct Timestamp { seconds: u64 } in the host module.

Originally posted by @romac in informalsystems/hermes#737 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: new-feature Objective: aims to add new feature A: good-first-issue Admin: good for newcomers labels Mar 22, 2021
@adizere adizere mentioned this issue Mar 22, 2021
Merged
5 tasks
@soareschen soareschen assigned soareschen and unassigned cezarad Apr 26, 2021
@soareschen
Copy link
Collaborator

To keep a better semantics of tracking the time, I will try to use define TimeStamp as a newtype over chrono::DateTime.

@soareschen soareschen mentioned this issue Apr 26, 2021
Merged
5 tasks
@ancazamfir ancazamfir mentioned this issue May 6, 2021
Merged
26 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
livelybug pushed a commit to octopus-network/ibc-rs that referenced this issue Oct 14, 2022
@adizere @ancazamfir
Disclosure log to record ICS3 liveness problems (cosmos#83)
e1b7894 
* Added disclosure log with 2 items.

* Fixed deadlock confusion; more details for each record

* More explanation for the second record in the disclosure log

* Apply suggestions from code review

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

* More thorough explanation and aligned record 2 with the default TLA+ spec.

* Aligned the trace w/ the most recent version of the spec.

* Apply suggestions from code review

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

* Update docs/disclosure-log.md

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

* Removed explicit reference to proofs (at h-1 vs. h) from item 2.

* Update docs/disclosure-log.md

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>

Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soareschen soareschen

Labels
A: good-first-issue Admin: good for newcomers O: new-feature Objective: aims to add new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soareschen @adizere @cezarad