Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: always set ics27 ports regardless of whether the capability exists #4640

Merged
merged 12 commits into from
Sep 14, 2023
Merged

refactor: always set ics27 ports regardless of whether the capability exists #4640

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
62b0fb3
refactor: always set ics27 ports regardless of whether the capability…
colin-axner Sep 12, 2023
69cb39f
test: add tests for host genesis logic
colin-axner Sep 13, 2023
dbf18a7
test: add controller genesis test and fixup host test
colin-axner Sep 13, 2023
12de9b9
Merge branch 'main' into colin/4626-ica-initgenesis-fix
colin-axner Sep 13, 2023
cc239e2
lint lint lint
colin-axner Sep 13, 2023
ec56a19
Merge branch 'colin/4626-ica-initgenesis-fix' of github.com:cosmos/ib…
colin-axner Sep 13, 2023
a36a978
fix: remove verification assertion in e2e as we have not checked for …
colin-axner Sep 13, 2023
7e22c19
Merge branch 'main' into colin/4626-ica-initgenesis-fix
colin-axner Sep 13, 2023
b8c2927
Merge branch 'main' into colin/4626-ica-initgenesis-fix
colin-axner Sep 13, 2023
05bd205
Merge branch 'main' into colin/4626-ica-initgenesis-fix
colin-axner Sep 14, 2023
0c72f48
Merge branch 'main' into colin/4626-ica-initgenesis-fix
colin-axner Sep 14, 2023
f981eb7
Merge branch 'main' into colin/4626-ica-initgenesis-fix
damiannolan Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions e2e/tests/upgrades/genesis_test.go
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy/pasted from ics27 tests

Original file line number Diff line number Diff line change
Expand Up @@ -180,17 +180,6 @@ func (s *GenesisTestSuite) TestIBCGenesis() {

s.Require().NoError(test.WaitForBlocks(ctx, 10, chainA, chainB))
})

t.Run("verify tokens transferred", func(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be added with #3476

balance, err := chainB.GetBalance(ctx, chainBAccount.FormattedAddress(), chainB.Config().Denom)
s.Require().NoError(err)

_, err = chainB.GetBalance(ctx, hostAccount, chainB.Config().Denom)
s.Require().NoError(err)

expected := testvalues.IBCTransferAmount + testvalues.StartingTokenAmount
s.Require().Equal(expected, balance.Int64())
})
})

s.Require().NoError(test.WaitForBlocks(ctx, 5, chainA, chainB), "failed to wait for blocks")
Expand Down