-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give callbacks its own go.mod (backport #4341) #4464
Give callbacks its own go.mod (backport #4341) #4464
Conversation
(cherry picked from commit a18159f) # Conflicts: # modules/apps/callbacks/export_test.go # modules/apps/callbacks/ibc_middleware.go
Important note: We still use
Regardless, a second release candidate is required for the replace statement to be removed. The second release candidate must be tagged after this PR is merged. |
.github/workflows/callbacks.yml
Outdated
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: '1.20' | ||
- uses: actions/checkout@v3 | ||
- uses: golangci/golangci-lint-action@v3.7.0 | ||
with: | ||
version: v1.53.3 | ||
args: --timeout 5m | ||
working-directory: modules/apps/callbacks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this from #4355.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is causing more trouble than anything else, I will take it out.
This is an automatic backport of pull request #4341 done by Mergify.
Cherry-pick of a18159f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com