Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proto): fix nested msg signer annoation #4336

Merged
merged 4 commits into from
Aug 14, 2023
Merged

fix(proto): fix nested msg signer annoation #4336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c55d343
fix(proto): fix nested msg signer annoation
julienrbrt Aug 14, 2023
77b698a
Merge branch 'main' into julien/fix-getsigner-annotations
damiannolan Aug 14, 2023
62979a7
Merge branch 'main' into julien/fix-getsigner-annotations
crodriguezvega Aug 14, 2023
ea7f0c3
Merge branch 'main' into julien/fix-getsigner-annotations
crodriguezvega Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 33 additions & 31 deletions modules/apps/29-fee/types/fee.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

85 changes: 42 additions & 43 deletions modules/apps/29-fee/types/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions proto/ibc/applications/fee/v1/fee.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ option go_package = "github.com/cosmos/ibc-go/v7/modules/apps/29-fee/types";
import "cosmos/base/v1beta1/coin.proto";
import "gogoproto/gogo.proto";
import "ibc/core/channel/v1/channel.proto";
import "cosmos/msg/v1/msg.proto";

// Fee defines the ICS29 receive, acknowledgement and timeout fees
message Fee {
Expand All @@ -23,6 +24,8 @@ message Fee {

// PacketFee contains ICS29 relayer fees, refund address and optional list of permitted relayers
message PacketFee {
option (cosmos.msg.v1.signer) = "refund_address";

// fee encapsulates the recv, ack and timeout fees associated with an IBC packet
Fee fee = 1 [(gogoproto.nullable) = false];
// the refund address for unspent fees
Expand Down
2 changes: 1 addition & 1 deletion proto/ibc/applications/fee/v1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ message MsgPayPacketFeeResponse {}
// MsgPayPacketFeeAsync defines the request type for the PayPacketFeeAsync rpc
// This Msg can be used to pay for a packet at a specified sequence (instead of the next sequence send)
message MsgPayPacketFeeAsync {
option (cosmos.msg.v1.signer) = "packet_fee.refundaddress";
option (cosmos.msg.v1.signer) = "packet_fee";
option (gogoproto.goproto_getters) = false;

// unique packet identifier comprised of the channel ID, port ID and sequence
Expand Down