chore: modify connection keeper GetTimestampAtHeight to use the client state interface function #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
reviewed
Jul 7, 2022
| @@ -34,4 +34,5 @@ var ( | |||
| ErrInvalidSubstitute = sdkerrors.Register(SubModuleName, 27, "invalid client state substitute") | |||
| ErrInvalidUpgradeProposal = sdkerrors.Register(SubModuleName, 28, "invalid upgrade proposal") | |||
| ErrClientNotActive = sdkerrors.Register(SubModuleName, 29, "client is not active") | |||
| ErrClientStateNotFound = sdkerrors.Register(SubModuleName, 30, "client state not found") | |||
There was a problem hiding this comment.
We already have ErrClientNotFound above so I think we can probably just use that!
There was a problem hiding this comment.
I'd also be okay with renaming ErrClientNotFound to ErrClientStateNotFound
There was a problem hiding this comment.
i'll do that, it's more explicit
Comment on lines
7
to
10
| "github.com/stretchr/testify/suite" | ||
|
|
||
| "github.com/cosmos/ibc-go/v3/modules/core/03-connection/types" | ||
| "github.com/cosmos/ibc-go/v3/modules/core/exported" | ||
| ibctesting "github.com/cosmos/ibc-go/v3/testing" | ||
| "github.com/stretchr/testify/suite" |
There was a problem hiding this comment.
nit: the testify import should stay above and separated from ibc-go imports
colin-axner
approved these changes
Jul 7, 2022
| @@ -34,4 +34,5 @@ var ( | |||
| ErrInvalidSubstitute = sdkerrors.Register(SubModuleName, 27, "invalid client state substitute") | |||
| ErrInvalidUpgradeProposal = sdkerrors.Register(SubModuleName, 28, "invalid upgrade proposal") | |||
| ErrClientNotActive = sdkerrors.Register(SubModuleName, 29, "client is not active") | |||
| ErrClientStateNotFound = sdkerrors.Register(SubModuleName, 30, "client state not found") | |||
There was a problem hiding this comment.
I'd also be okay with renaming ErrClientNotFound to ErrClientStateNotFound
| @@ -177,6 +177,23 @@ func (suite *KeeperTestSuite) TestSendPacket() { | |||
| packet = types.NewPacket(ibctesting.MockPacketData, 1, path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID, path.EndpointB.ChannelConfig.PortID, path.EndpointB.ChannelID, disabledTimeoutHeight, timestamp) | |||
| channelCap = suite.chainA.GetChannelCapability(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID) | |||
| }, false}, | |||
| {"timeout timestamp passed with solomachine", func() { | |||
There was a problem hiding this comment.
should we open an issue to add solomachine tests for timeout_test.go functions?
oshorefueled
pushed a commit
to ComposableFi/ibc-go
that referenced
this pull request
Aug 9, 2022
…t state interface function (cosmos#1666) * updated connection keeper to use clientstate to get timestamp, updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #876
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes