Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc-go documentation website #146

Merged
merged 7 commits into from
May 4, 2021
Merged

ibc-go documentation website #146

merged 7 commits into from
May 4, 2021

Conversation

colin-axner
Copy link
Contributor

Description

Get a documentation website up for ibc-go so we can remove docs from SDK and maintain them here

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner
Copy link
Contributor Author

Current render
Screenshot_2021-05-03 IBC Go Documentation IBC-Go

Marking as ready for review, because I'm not sure how much further I'll get on my own

@colin-axner colin-axner marked this pull request as ready for review May 3, 2021 16:48
@colin-axner colin-axner enabled auto-merge (squash) May 4, 2021 10:12
@colin-axner colin-axner merged commit e012a4a into main May 4, 2021
@colin-axner colin-axner deleted the colin/ibcgo-docs branch May 4, 2021 10:13
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
…mos#146)

* update `MockDataAvailabilityLayerClient` to use `KVStore` instead of maps
* ensure that `KVStore` is passed to `Init` in the tests

Resolves cosmos#134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants