Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go vet to detect issues with invalid struct tags #689

Closed
2 of 3 tasks
crodriguezvega opened this issue Jan 7, 2022 · 1 comment
Closed
2 of 3 tasks

Use go vet to detect issues with invalid struct tags #689

crodriguezvega opened this issue Jan 7, 2022 · 1 comment
Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@crodriguezvega
Copy link
Contributor

Problem Definition

During the Trail of Bits audit of Interchain Accounts an issue with an invalid struct tag in a field of a generated protobuf structure was found when running go vet.

Proposal

Add go vet to our CI pipeline.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added ci type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Jan 7, 2022
@crodriguezvega crodriguezvega removed the ci label Mar 31, 2023
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal
Use consistent hash type across headers (cosmos#698)
9bf4b1d 
Closes cosmos#689
@crodriguezvega
Copy link
Contributor Author

We are using the govet linter, so we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crodriguezvega