-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move connection identifiers in interchain accounts port ID to version #615
Comments
I think if we are going with this we should probably JSON encode the payload into a typed |
As in create a type for the version and JSON encode it? Seems reasonable to me. We won't have to do string parsing, client side representation of the version will be quite ugly I think |
Yeah exactly, what we were talking about before. I think with adding more fields to the version parsing could just get out of hand and JSON encoding would be somewhat cleaner. Do you mean ugly with the JSON encoding or ugly with extra fields? I think it would be ugly either way I guess 🤣 |
How will the JSON encoding look when printed as a string? I guess it might look fine? I think using a type is probably a good idea in this instance |
…hub.com/spf13/viper-1.9.0 Bump github.com/spf13/viper from 1.8.1 to 1.9.0
Summary
Move the connection ID and counterparty connection ID numbers from the portID to the channel version.
Problem Definition
We recently discussed the possibility of creating ORDERED channels which do not close on packet timeouts. This makes channel recovery in interchain accounts a lot less necessary. If we decide to pursue this change in the future, changing the port ID format will be very difficult, thus it seems desirable to move these fields, which may not be necessary in the future, to the version which can be changed.
For Admin Use
The text was updated successfully, but these errors were encountered: