-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Default ProofSpecs for SDK SMT change #559
Comments
@AdityaSripal I think at the moment hermes is using these default proof specs in the |
We need to implement a query that is available on all chains so that relayers can simply query the chain to determine what proof specs to use for the client. cc: @colin-axner |
Wasmvm upgrade 557
Why there is a default proof spec? Shoudn't that be implied by the SDK / IBC config? Default sounds dangerous here - what if someone will forget to configure? |
Thanks for the comment, @robert-zaremba. Yes, I guess you're right and it would be more flexible if ibc-go could dynamically figure out what proof specs to use. @AdityaSripal, any idea if this could be feasible? |
can we close this? IIRC sdk do not plan to migrate away from iavl anytime soon? |
Bumps [github.com/dgraph-io/badger/v3](https://github.com/dgraph-io/badger) from 3.2103.2 to 3.2103.3. - [Release notes](https://github.com/dgraph-io/badger/releases) - [Changelog](https://github.com/dgraph-io/badger/blob/v3.2103.3/CHANGELOG.md) - [Commits](hypermodeinc/badger@v3.2103.2...v3.2103.3) --- updated-dependencies: - dependency-name: github.com/dgraph-io/badger/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
When the SDK SMT change comes in, we'll have to change our default proofspecs to reflect the new proofspecs for SDK chains.
This would involve changing the following line:
https://github.com/cosmos/ibc-go/blob/main/modules/core/23-commitment/types/merkle.go#L17
to
SMTSpec, TendermintSpec
and then testing the combined SDK/IBC changes
The text was updated successfully, but these errors were encountered: