Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to TrySendTx function #459

Closed
3 tasks
colin-axner opened this issue Sep 30, 2021 · 1 comment
Closed
3 tasks

Add type to TrySendTx function #459

colin-axner opened this issue Sep 30, 2021 · 1 comment
Labels
27-interchain-accounts
Milestone
Interchain Accounts

Comments

@colin-axner
Copy link
Contributor

Summary

TrySendTx hardcodes the type to EXECUTE_TX. We should pass in the type to account for future types without having to break the API

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the Interchain Accounts milestone Sep 30, 2021
@damiannolan
Copy link
Contributor

Closed by #474

@crodriguezvega crodriguezvega moved this to Done in ibc-go Dec 30, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Merge pull request cosmos#459 from CosmWasm/grpc_query_nil_416

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
356d786 
Handle nil in grpc querier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
27-interchain-accounts
Projects
No open projects
ibc-go
Archived in project
Milestone
Interchain Accounts
Development

No branches or pull requests
2 participants
@damiannolan @colin-axner