nit: use collections.Contains when checking for supported encoding, t…

…x and feature. (#4197)

modules/apps/27-interchain-accounts/types/metadata.go

@@ -5,6 +5,7 @@ import (
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
+	"github.com/cosmos/ibc-go/v7/internal/collections"
 	connectiontypes "github.com/cosmos/ibc-go/v7/modules/core/03-connection/types"
 )
 
@@ -133,13 +134,7 @@ func ValidateHostMetadata(ctx sdk.Context, channelKeeper ChannelKeeper, connecti
 
 // isSupportedEncoding returns true if the provided encoding is supported, otherwise false
 func isSupportedEncoding(encoding string) bool {
-	for _, enc := range getSupportedEncoding() {
-		if enc == encoding {
-			return true
-		}
-	}
-
-	return false
+	return collections.Contains(encoding, getSupportedEncoding())
 }
 
 // getSupportedEncoding returns a string slice of supported encoding formats
@@ -149,13 +144,7 @@ func getSupportedEncoding() []string {
 
 // isSupportedTxType returns true if the provided transaction type is supported, otherwise false
 func isSupportedTxType(txType string) bool {
-	for _, t := range getSupportedTxTypes() {
-		if t == txType {
-			return true
-		}
-	}
-
-	return false
+	return collections.Contains(txType, getSupportedTxTypes())
 }
 
 // getSupportedTxTypes returns a string slice of supported transaction types

modules/core/03-connection/types/version.go

@@ -5,7 +5,7 @@ import (
 
 	errorsmod "cosmossdk.io/errors"
 
-	collections "github.com/cosmos/ibc-go/v7/internal/collections"
+	"github.com/cosmos/ibc-go/v7/internal/collections"
 )
 
 var (
@@ -100,12 +100,7 @@ func (version Version) VerifyProposedVersion(proposedVersion *Version) error {
 // VerifySupportedFeature takes in a version and feature string and returns
 // true if the feature is supported by the version and false otherwise.
 func VerifySupportedFeature(version *Version, feature string) bool {
-	for _, f := range version.GetFeatures() {
-		if f == feature {
-			return true
-		}
-	}
-	return false
+	return collections.Contains(feature, version.GetFeatures())
 }
 
 // GetCompatibleVersions returns a descending ordered set of compatible IBC