Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate proposed genesis state in InitGenesis #90

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

jtieri
Copy link
Member

@jtieri jtieri commented Aug 31, 2023

When genesis initialization takes place in InitGenesis we were not explicitly calling ValidateGenesis on the proposed genesis state. This was allowing invalid data to be written to the store.

Closes #46

@jtieri jtieri added BACKPORT Backport into maintained branches packet-forward-middleware Label for items related to the packet forward middleware labels Aug 31, 2023
@jtieri jtieri requested review from agouin and boojamya September 11, 2023 17:40
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@jtieri jtieri merged commit 5bb6779 into main Sep 19, 2023
@jtieri jtieri deleted the justin/fix-val branch September 19, 2023 17:54
mergify bot pushed a commit that referenced this pull request Sep 19, 2023
mergify bot pushed a commit that referenced this pull request Sep 19, 2023
mergify bot pushed a commit that referenced this pull request Sep 19, 2023
jtieri added a commit that referenced this pull request Sep 19, 2023
(cherry picked from commit 5bb6779)

Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
jtieri added a commit that referenced this pull request Sep 19, 2023
(cherry picked from commit 5bb6779)

Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
jtieri added a commit that referenced this pull request Sep 19, 2023
(cherry picked from commit 5bb6779)

Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BACKPORT Backport into maintained branches packet-forward-middleware Label for items related to the packet forward middleware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PFM: FeePercentage param should default to zero if not set
2 participants