fix!: queries that panic should return ack-err
#86
Conversation
ack-errack-err
There was a problem hiding this comment.
thanks for the contribution and sorry for the slow turnaround time on this one!
my one request would be to move cache_ctx.go into the keeper package since that is where code is being invoked at. then we can delete the utils package and make these functions unexported. my reasoning being that having packages named utils, helpers, common, etc. often feels like an anti-pattern and if the code is only being called in one place we can move the code there so it's more clear where it's utilized. it also allows us to encapsulate these functions so the exposed api is succinct.
|
hey @VitalyVolozhinov wanted to ping you and see if there is an update on this? if i don't hear back from you I can address the couple nit picks that i mentioned and we can get this merged. thanks again for your contributions! |
|
Thank you for reminding me about this! I've updated the code as per suggestion. Thank you! |
and thank you again for your contributions, they are greatly appreciated 🙂 |
ack-errack-err
|
These changes should be included in the next minor releases of |
* adding ApplyFuncIfNoError * Moving cache_ctx.go to the keeper * updating comment * chore: address linter errors --------- Co-authored-by: jtieri <justin@thetieris.com> (cherry picked from commit 83f866e) # Conflicts: # modules/async-icq/testing/demo-simapp/app/export.go
* adding ApplyFuncIfNoError * Moving cache_ctx.go to the keeper * updating comment * chore: address linter errors --------- Co-authored-by: jtieri <justin@thetieris.com> (cherry picked from commit 83f866e) # Conflicts: # modules/async-icq/testing/demo-simapp/app/export.go
* adding ApplyFuncIfNoError * Moving cache_ctx.go to the keeper * updating comment * chore: address linter errors --------- Co-authored-by: jtieri <justin@thetieris.com> (cherry picked from commit 83f866e) # Conflicts: # modules/async-icq/testing/demo-simapp/app/export.go
…-err` (#137) * fix!: queries that panic should return `ack-err` (#86) * adding ApplyFuncIfNoError * Moving cache_ctx.go to the keeper * updating comment * chore: address linter errors --------- Co-authored-by: jtieri <justin@thetieris.com> (cherry picked from commit 83f866e) # Conflicts: # modules/async-icq/testing/demo-simapp/app/export.go * fix: remove demo simapp code that was never backported --------- Co-authored-by: Vitaly Volozhinov <60775046+VitalyVolozhinov@users.noreply.github.com> Co-authored-by: jtieri <justin@thetieris.com>
…-err` (#138) * fix!: queries that panic should return `ack-err` (#86) * adding ApplyFuncIfNoError * Moving cache_ctx.go to the keeper * updating comment * chore: address linter errors --------- Co-authored-by: jtieri <justin@thetieris.com> (cherry picked from commit 83f866e) # Conflicts: # modules/async-icq/testing/demo-simapp/app/export.go * fix: remove demo simapp code that was never backported --------- Co-authored-by: Vitaly Volozhinov <60775046+VitalyVolozhinov@users.noreply.github.com> Co-authored-by: jtieri <justin@thetieris.com>
…-err` (#139) * fix!: queries that panic should return `ack-err` (#86) * adding ApplyFuncIfNoError * Moving cache_ctx.go to the keeper * updating comment * chore: address linter errors --------- Co-authored-by: jtieri <justin@thetieris.com> (cherry picked from commit 83f866e) # Conflicts: # modules/async-icq/testing/demo-simapp/app/export.go * fix: remove demo simapp code that was never backported --------- Co-authored-by: Vitaly Volozhinov <60775046+VitalyVolozhinov@users.noreply.github.com> Co-authored-by: jtieri <justin@thetieris.com>
Closes #85