Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP: release/v6 <- #222] feat: add storage leak test #224

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 22, 2024

Previously, flight packets were retained in the module's storage after a packet timeout. Now, flight packets are correctly removed when they timeout. An additional test was also added to verify that flight packets are correctly removed and not retained in storage after a timeout.


This is an automatic backport of pull request #222 done by Mergify.

* feat: add storage leak test

* cleanup test

* add e2e to workflow

(cherry picked from commit 64c5cd5)

# Conflicts:
#	.github/workflows/packet-forward-middleware.yml
#	middleware/packet-forward-middleware/Makefile
Copy link
Author

mergify bot commented Nov 22, 2024

Cherry-pick of 64c5cd5 has failed:

On branch mergify/bp/release/v6/pr-222
Your branch is up to date with 'origin/release/v6'.

You are currently cherry-picking commit 64c5cd5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   middleware/packet-forward-middleware/e2e/storage_leak_test.go
	modified:   middleware/packet-forward-middleware/packetforward/ibc_middleware.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/packet-forward-middleware.yml
	both modified:   middleware/packet-forward-middleware/Makefile

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant