Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade sequence diagrams from ASCII to Mermaid. #158

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Upgrade sequence diagrams from ASCII to Mermaid. #158

merged 1 commit into from
Jan 9, 2024

Conversation

jonathanpberger
Copy link
Contributor

  • Alignment is tricky in the ASCII version, making sequence a bit hard to parse
  • It's prettier!

@jonathanpberger
Upgrade sequence diagrams from ASCII to Mermaid.
cded722 
- Alignment is tricky in the ASCII version, making sequence a bit hard to parse
- It's prettier!
@github-actions github-actions bot added the packet-forward-middleware Label for items related to the packet forward middleware label Jan 8, 2024
jtieri
jtieri approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new sequence diagrams are 🔥

a test case seems to be failing in CI, i'll fix this in a follow up PR

@jtieri jtieri added documentation Improvements or additions to documentation BACKPORT Backport into maintained branches labels Jan 9, 2024
@jtieri jtieri merged commit b152a63 into main Jan 9, 2024
8 of 9 checks passed
@jtieri jtieri deleted the mermaid-sequence-diagrams branch January 9, 2024 20:23
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
@jonathanpberger @mergify
Upgrade sequence diagrams from ASCII to Mermaid. (#158)
1367271 
- Alignment is tricky in the ASCII version, making sequence a bit hard to parse
- It's prettier!

(cherry picked from commit b152a63)
@mergify mergify bot mentioned this pull request Jan 9, 2024
Closed
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
@jonathanpberger @mergify
Upgrade sequence diagrams from ASCII to Mermaid. (#158)
c2385f2 
- Alignment is tricky in the ASCII version, making sequence a bit hard to parse
- It's prettier!

(cherry picked from commit b152a63)
@mergify mergify bot mentioned this pull request Jan 9, 2024
Closed
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
@jonathanpberger @mergify
Upgrade sequence diagrams from ASCII to Mermaid. (#158)
8f4ea11 
- Alignment is tricky in the ASCII version, making sequence a bit hard to parse
- It's prettier!

(cherry picked from commit b152a63)
@mergify mergify bot mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri approved these changes

Assignees
No one assigned
Labels
BACKPORT Backport into maintained branches documentation Improvements or additions to documentation packet-forward-middleware Label for items related to the packet forward middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanpberger @jtieri