Skip to content

Commit

Permalink
chore: remove unused Keeper argument (#140)
Browse files Browse the repository at this point in the history
* chore: rm unused Subspace in keeper

* lint
  • Loading branch information
Reecepbcups authored Nov 12, 2023
1 parent 83f866e commit 3ccc1a7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
14 changes: 3 additions & 11 deletions modules/async-icq/keeper/keeper.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
sdk "github.com/cosmos/cosmos-sdk/types"
capabilitykeeper "github.com/cosmos/cosmos-sdk/x/capability/keeper"
capabilitytypes "github.com/cosmos/cosmos-sdk/x/capability/types"
paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"

"github.com/cometbft/cometbft/libs/log"

Expand All @@ -21,9 +20,8 @@ import (

// Keeper defines the IBC interchain query host keeper
type Keeper struct {
storeKey storetypes.StoreKey
cdc codec.BinaryCodec
paramSpace paramtypes.Subspace
storeKey storetypes.StoreKey
cdc codec.BinaryCodec

ics4Wrapper types.ICS4Wrapper
channelKeeper types.ChannelKeeper
Expand All @@ -40,19 +38,13 @@ type Keeper struct {

// NewKeeper creates a new interchain query Keeper instance
func NewKeeper(
cdc codec.BinaryCodec, key storetypes.StoreKey, paramSpace paramtypes.Subspace,
cdc codec.BinaryCodec, key storetypes.StoreKey,
ics4Wrapper types.ICS4Wrapper, channelKeeper types.ChannelKeeper, portKeeper types.PortKeeper,
scopedKeeper capabilitykeeper.ScopedKeeper, queryRouter *baseapp.GRPCQueryRouter, authority string,
) Keeper {
// set KeyTable if it has not already been set
if !paramSpace.HasKeyTable() {
paramSpace = paramSpace.WithKeyTable(types.ParamKeyTable())
}

return Keeper{
storeKey: key,
cdc: cdc,
paramSpace: paramSpace,
ics4Wrapper: ics4Wrapper,
channelKeeper: channelKeeper,
portKeeper: portKeeper,
Expand Down
1 change: 0 additions & 1 deletion modules/async-icq/testing/simapp/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,6 @@ func NewSimApp(
app.ICQKeeper = icqkeeper.NewKeeper(
appCodec,
keys[icqtypes.StoreKey],
app.GetSubspace(icqtypes.ModuleName),
app.IBCKeeper.ChannelKeeper, // may be replaced with middleware
app.IBCKeeper.ChannelKeeper,
&app.IBCKeeper.PortKeeper,
Expand Down

0 comments on commit 3ccc1a7

Please sign in to comment.