-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache first version for legacy versions (backport #1018) #1020
Conversation
(cherry picked from commit e60601d) # Conflicts: # CHANGELOG.md
Cherry-pick of e60601d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fix performance regression after upgrade.
Context
We see higher cpu usage in rpc nodes when serving similar traffic of queries, we dump a golang trace and see following stacktrace appears frequently, we suspect this to be the issue.
The first version in ndb seems should be cached, but it's not in legacy version case, which cause an extra seek call to underlying db, and the extra call happens for each store and for each query request.
We've verified this fix reduce the cpu usage on the nodes quite effective.
Summary by CodeRabbit
New Features
DeleteVersionsFrom(int64)
andGetLatestVersion
.Bug Fixes
GetNode
.Improvements
Documentation
This is an automatic backport of pull request #1018 done by [Mergify](https://mergify.com).