Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache first version for legacy versions (backport #1018) #1020

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 16, 2024

fix performance regression after upgrade.

Context

We see higher cpu usage in rpc nodes when serving similar traffic of queries, we dump a golang trace and see following stacktrace appears frequently, we suspect this to be the issue.
The first version in ndb seems should be cached, but it's not in legacy version case, which cause an extra seek call to underlying db, and the extra call happens for each store and for each query request.

github.com/linxGnu/grocksdb._Cfunc_rocksdb_iter_seek:3593
--
github.com/linxGnu/grocksdb.(*Iterator).Seek.func1:108
github.com/linxGnu/grocksdb.(*Iterator).Seek:108
github.com/cosmos/cosmos-db.newRocksDBIterator:40
github.com/cosmos/cosmos-db.(*RocksDB).Iterator:215
github.com/cosmos/cosmos-db.(*PrefixDB).Iterator:112
cosmossdk.io/store/wrapper.(*DBWrapper).Iterator:29
github.com/cosmos/iavl.(*nodeDB).getPrefixIterator:1002
github.com/cosmos/iavl.(*nodeDB).getFirstVersion:735
github.com/cosmos/iavl.(*MutableTree).VersionExists:88
cosmossdk.io/store/iavl.(*Store).VersionExists:176
cosmossdk.io/store/iavl.(*Store).GetImmutable:109
cosmossdk.io/store/rootmulti.(*Store).CacheMultiStoreWithVersion:612
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).CreateQueryContext:1270
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).RegisterGRPCServer.func1:49
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).RegisterGRPCServer.func2.ChainUnaryServer.2.1:48
github.com/grpc-ecosystem/go-grpc-middleware/recovery.UnaryServerInterceptor.func1:33
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).RegisterGRPCServer.func2.ChainUnaryServer.2:53

We've verified this fix reduce the cpu usage on the nodes quite effective.

Summary by CodeRabbit

  • New Features

    • Introduced new APIs: DeleteVersionsFrom(int64) and GetLatestVersion.
  • Bug Fixes

    • Added extra check for reformatted root node in GetNode.
    • Fixed performance regression by caching the first version for legacy versions.
  • Improvements

    • Enhanced error handling for node retrieval methods.
    • Improved version management within the database.
  • Documentation

    • Updated changelog with new entries for bug fixes and improvements.

This is an automatic backport of pull request #1018 done by [Mergify](https://mergify.com).

(cherry picked from commit e60601d)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from a team as a code owner December 16, 2024 17:08
@mergify mergify bot added the conflicts label Dec 16, 2024
Copy link
Contributor Author

mergify bot commented Dec 16, 2024

Cherry-pick of e60601d has failed:

On branch mergify/bp/release/v1.3.x/pr-1018
Your branch is up to date with 'origin/release/v1.3.x'.

You are currently cherry-picking commit e60601d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   nodedb.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

coderabbitai bot commented Dec 16, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tac0turtle tac0turtle enabled auto-merge (squash) December 16, 2024 17:10
@tac0turtle tac0turtle merged commit a6e703c into release/v1.3.x Dec 16, 2024
3 of 5 checks passed
@tac0turtle tac0turtle deleted the mergify/bp/release/v1.3.x/pr-1018 branch December 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants