Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add go version check #2095

Merged
merged 3 commits into from
Jan 30, 2023
Merged

feat: Add go version check #2095

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b49bc62
Add go version check
Jan 29, 2023
2f4ce3a
Merge branch 'main' into glnro/version-warning
glnro Jan 30, 2023
a97fd8c
Make requested changes
Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ DOCKER := $(shell which docker)
BUILDDIR ?= $(CURDIR)/build
TEST_DOCKER_REPO=cosmos/contrib-gaiatest

GO_MAJOR_VERSION = $(shell go version | cut -c 14- | cut -d' ' -f1 | cut -d'.' -f1)
GO_MINOR_VERSION = $(shell go version | cut -c 14- | cut -d' ' -f1 | cut -d'.' -f2)

export GO111MODULE = on

# process build tags
Expand Down Expand Up @@ -89,16 +92,22 @@ endif
include contrib/devtools/Makefile

###############################################################################
### Documentation ###
### Build ###
###############################################################################

check_version:
ifneq ($(GO_MINOR_VERSION),18)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be a problem with checking against 1.18 or even >= 1.18?

Also, would it be possible to make the hardcoded 18 const into a var?

REQUIRE_GO_VERSION = '1.18'

@echo "ERROR: Go version 1.18 is required for $(VERSION) of Gaia."
exit 1
endif

all: install lint run-tests test-e2e vulncheck

BUILD_TARGETS := build install

build: BUILD_ARGS=-o $(BUILDDIR)/

$(BUILD_TARGETS): go.sum $(BUILDDIR)/
$(BUILD_TARGETS): check_version go.sum $(BUILDDIR)/
go $@ -mod=readonly $(BUILD_FLAGS) $(BUILD_ARGS) ./...

$(BUILDDIR)/:
Expand Down