Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): remove queries as IntegrationTestSuite object #1780

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

Pantani
Copy link
Contributor

@Pantani Pantani commented Oct 4, 2022

Description

Some queries are methods extensions from the IntegrationTestSuite object, but can be static functions.

  • All queries are moved to the querie.go and all exec commands to e2e_exec_test.go.
  • Use httpGet instead http.Get
  • Use module moduleName variable as part of the gaiad CLI command

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #1780 (52f9743) into main (c7ae176) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1780   +/-   ##
=======================================
  Coverage   52.33%   52.33%           
=======================================
  Files          16       16           
  Lines        1779     1779           
=======================================
  Hits          931      931           
  Misses        821      821           
  Partials       27       27           

@mmulji-ic mmulji-ic merged commit da1ae4f into main Oct 5, 2022
@mmulji-ic mmulji-ic deleted the chore/move-querie-file branch October 5, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants