-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC: fix server reflection (backport #8945) #9253
Conversation
* add: gogoreflection * fix: server reflection * fix: make tests resolve imports in a transitive way * chore: cleanup getMessageType * chore: lint * add: extensions reflection * chore: update interact-node.md docs * chore: update CHANGELOG.md * Update server/grpc/gogoreflection/fix_registration.go Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Jonathan Gimeno <jgimeno@gmail.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> (cherry picked from commit ac48ffe) # Conflicts: # CHANGELOG.md # go.mod # go.sum
Hmm, there's a weird error:
i can take a look (unless if @fdymylja you have an immediate idea what's happening?) |
@AmauryM https://github.com/confio/ics23/blob/master/go/proofs.pb.go#L1158 proofs registers itself as proof.proto but is imported most likely by IBC as confio/proofs.proto which causes reflectiont to fail because the file in the registry is registered with a different path compared to how descriptors import it as. |
@@ -4,7 +4,7 @@ package ibc.core.commitment.v1; | |||
option go_package = "github.com/cosmos/cosmos-sdk/x/ibc/core/23-commitment/types"; | |||
|
|||
import "gogoproto/gogo.proto"; | |||
import "confio/proofs.proto"; | |||
import "proofs.proto"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunate (ref: #9253 (comment)). In 07cf792 I moved proofs.proto to the third_party/proto root folder.
Does this workaround work for you @fdymylja?
Is the correct way of solving this to create a PR on https://github.com/confio/ics23/ to move the proofs.proto
file there into a confio
subfolder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative is just to not backport this fix...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @robert-zaremba, let's just not backport this PR, and ask people to use 0.43 if they want server reflection.
We skip this PR. The fix here is only gRPC related. It doesn't break any logical flow nor existing tools nor is related to security. This feature did not work in the past. gRPC is reflection is correctly implemented in v0.43. We just released beta ( |
This is an automatic backport of pull request #8945 done by Mergify.
Cherry-pick of ac48ffe has failed:
To fix up this pull request, you can check it out locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/