x/bank/types: fix AddressFromBalancesStore panics with invalid keys #9061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @odeke-em |
Codecov Report
@@ Coverage Diff @@
## master #9061 +/- ##
==========================================
- Coverage 58.95% 58.95% -0.01%
==========================================
Files 574 574
Lines 32213 32220 +7
==========================================
+ Hits 18992 18996 +4
- Misses 11002 11004 +2
- Partials 2219 2220 +1
|
odeke-em
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
LGTM, thank you @cuonglm! I've filed an issue for it #9062, so please update the commit message and also the message on the PR to indicate a Fixes #NNNN
/cc @marbar3778 @alessio
amaury1093
reviewed
Apr 7, 2021
amaury1093
suggested changes
Apr 7, 2021
|
@cuonglm, let’s just panic and test that we panic on bad inputs and then
lock that in. Thanks @AmauryM for the input, and great point about avoid
0x00 as an address.
…On Wed, Apr 7, 2021 at 4:34 AM Amaury ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Blocking for now. Would like to avoid manipulating sdk.AccAddress(0x00).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9061 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3VY7Q6WD7BUMNV66JATTHQ7KVANCNFSM42QEIMTA>
.
|
amaury1093
reviewed
Apr 7, 2021
amaury1093
reviewed
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, AddressFromBalancesStore uses the input key without any
validation, so an empty key or an invalid key length cause it panics.
This commit fixes the problem, by introducing new InvalidKey type, which
will be returned to the caller when an invalid key was passed.
Found by fuzzing added in #9060.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes