Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: allow 0 coin accounts in genesis (bp #8714) #8716

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 26, 2021

This is an automatic backport of pull request #8714 done by Mergify.

Cherry-pick of a786830 has failed:

On branch mergify/bp/release/v0.41.x/pr-8714
Your branch is up to date with 'origin/release/v0.41.x'.

You are currently cherry-picking commit a786830bb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/bank/types/balance.go
	modified:   x/bank/types/balance_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x/bank/types/genesis_test.go

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* allow zero accounts

* fix test

* fix test

(cherry picked from commit a786830)

# Conflicts:
#	x/bank/types/genesis_test.go
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #8716 (06e6cca) into release/v0.41.x (2a5818c) will increase coverage by 0.00%.
The diff coverage is 57.57%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/v0.41.x    #8716    +/-   ##
=================================================
  Coverage            61.93%   61.93%            
=================================================
  Files                  611      611            
  Lines                35250    35357   +107     
=================================================
+ Hits                 21831    21900    +69     
- Misses               11136    11158    +22     
- Partials              2283     2299    +16     
Impacted Files Coverage Δ
baseapp/grpcserver.go 2.70% <0.00%> (+0.13%) ⬆️
store/rootmulti/store.go 66.05% <0.00%> (ø)
testutil/network/network.go 90.54% <0.00%> (ø)
x/bank/types/balance.go 60.71% <ø> (-2.62%) ⬇️
x/staking/keeper/keeper.go 56.66% <ø> (-1.40%) ⬇️
x/staking/keeper/validator.go 80.52% <ø> (+0.03%) ⬆️
client/grpc_query.go 29.16% <40.00%> (+0.90%) ⬆️
baseapp/grpcrouter.go 80.00% <50.00%> (-6.05%) ⬇️
x/auth/client/cli/tx_multisign.go 64.67% <66.11%> (+2.99%) ⬆️
codec/types/any.go 64.00% <100.00%> (+3.13%) ⬆️
... and 9 more

@alessio alessio added this to the v0.41.4 milestone Feb 26, 2021
@alessio alessio merged commit 16fbb50 into release/v0.41.x Feb 26, 2021
@alessio alessio deleted the mergify/bp/release/v0.41.x/pr-8714 branch February 26, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants