Added glossary explaning Denomination Key #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading this ADR, I was confused about _denomination_. When reading this in context of tokens I always think about a unit / measure. Examples: bills denominated in $20 and $50. Or as 100 cents makes 1 dollar. The Merriam-Webster dictionary defines [denomination](https://www.merriam-webster.com/dictionary/denomination) as: 1. an act of denominating. Eg: the denomination of prices in U.S. dollars 2. a value or size of a series of values or sizes. Eg: metric denominations 3. name, designation especially : a general name for a category It seams that we are using the last definition (3rd).
alessio
approved these changes
Sep 16, 2020
aaronc
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading this ADR, I was confused about denomination. When reading this in context of tokens I always think about a unit / measure. Examples: bills denominated in $20 and $50. Or 100 cents make 1 dollar.
The Merriam-Webster dictionary defines denomination as:
It seams that we are using the last definition (3rd).
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes