-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: refactor flag reading #6884
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6884 +/- ##
==========================================
+ Coverage 61.40% 61.42% +0.02%
==========================================
Files 517 517
Lines 32050 32059 +9
==========================================
+ Hits 19679 19692 +13
+ Misses 10802 10799 -3
+ Partials 1569 1568 -1 |
alexanderbez
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
July 29, 2020 20:36
alexanderbez
added
A:automerge
Automatically merge PR once all prerequisites pass.
C:CLI
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
labels
Jul 29, 2020
…smos-sdk into bez/refactor-cmd-flags-helpers
aaronc
reviewed
Jul 29, 2020
fedekunze
approved these changes
Jul 30, 2020
aaronc
removed
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Jul 30, 2020
aaronc
approved these changes
Jul 30, 2020
ACK'ed but removed automerge. I'd leave it up to you how best to manage these flags. |
alexanderbez
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A:automerge
Automatically merge PR once all prerequisites pass.
C:CLI
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaner and consistent flag reading in ALL CLI auxiliary functions for
client.Context
building.client.Context
field not pre-populated & flag not set -> uses default flag value ✅client.Context
field not pre-populated & flag set -> uses set flag value ✅client.Context
field pre-populated & flag not set -> uses pre-populated value ✅client.Context
field pre-populated & flag set -> uses set flag value ✅Checking
clientCtx
allows us to cover cases 1-3 and checkingflagSet.Changed
allows us to handle case 4.ref: #6717 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes