Add pagination response for commands #6825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6825 +/- ##
=======================================
Coverage 62.01% 62.01%
=======================================
Files 519 519
Lines 32060 32060
=======================================
Hits 19883 19883
Misses 10559 10559
Partials 1618 1618 |
…sdk into atheesh/5921-missing-grpc
anilcse
approved these changes
Aug 6, 2020
| @@ -342,7 +342,7 @@ $ %s query staking delegations cosmos1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p | |||
| return err | |||
| } | |||
|
|
|||
| return clientCtx.PrintOutput(res.DelegationResponses) | |||
| return clientCtx.PrintOutput(res) | |||
There was a problem hiding this comment.
We should add cli-tests for these queries, I remember @sahith-narahari working on querier tests?
…sdk into atheesh/5921-missing-grpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5921
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes