Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/auth: cli gRPC migration #6809

Merged
merged 5 commits into from
Jul 21, 2020
Merged

x/auth: cli gRPC migration #6809

merged 5 commits into from
Jul 21, 2020

Conversation

atheeshp
Copy link
Contributor

ref: #5921

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@atheeshp atheeshp marked this pull request as ready for review July 21, 2020 17:32
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@97a83e9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6809   +/-   ##
=========================================
  Coverage          ?   59.00%           
=========================================
  Files             ?      343           
  Lines             ?    20276           
  Branches          ?        0           
=========================================
  Hits              ?    11964           
  Misses            ?     7406           
  Partials          ?      906           

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@anilcse anilcse added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 21, 2020
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mergify mergify bot merged commit 470465d into master Jul 21, 2020
@mergify mergify bot deleted the atheesh/5921-x-auth branch July 21, 2020 17:48
@aaronc aaronc mentioned this pull request Jul 21, 2020
43 tasks
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
* migrated auth cli to use grpc query client

* unpacker added for account command

* fxed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants