-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/staking: cli migration to use gRPC query client #6728
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a340052
migrated to use gRPC query client
atheeshp 12940d3
removed codecs usage
atheeshp dd571a7
Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…
atheeshp aa6699c
review change
atheeshp 3f15bd3
Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…
atheeshp cdd0a39
added read command flags
atheeshp 8548f3d
Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…
atheeshp b660b0a
Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…
atheeshp 2bfb3d5
Merge branch 'master' into atheesh/5921-grpc-cli-migration-staking
fedekunze 2deb1fb
Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…
atheeshp 316c55e
added pagination flags
atheeshp 082d3a8
Merge branch 'atheesh/5921-grpc-cli-migration-staking' of github.com:…
atheeshp daefb37
fixed limit issue
atheeshp 4f5e201
added helper function for default pagination flags
atheeshp c094491
Merge branch 'master' of github.com:cosmos/cosmos-sdk into atheesh/59…
atheeshp 88f2aae
Merge branch 'master' into atheesh/5921-grpc-cli-migration-staking
mergify[bot] c665872
review changes
atheeshp bf3273a
Merge branch 'atheesh/5921-grpc-cli-migration-staking' of github.com:…
atheeshp 08d2548
review change
atheeshp 956183d
review changes
atheeshp 34b21d6
Merge branch 'master' into atheesh/5921-grpc-cli-migration-staking
mergify[bot] 3c742e9
Merge branch 'master' into atheesh/5921-grpc-cli-migration-staking
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be yes after all module migrations done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, agreed with @atheeshp: auth,ibc,evidence,gov etc are all using FlagPage, probably should wait for those modules to switch to using gRPC & query.PageRequest first, or else this PR will become too big.