Fix Gas Flag Usage + CLI Flag APIs #6685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6685 +/- ##
==========================================
- Coverage 58.36% 53.94% -4.43%
==========================================
Files 503 338 -165
Lines 30226 19456 -10770
==========================================
- Hits 17641 10495 -7146
+ Misses 11295 8239 -3056
+ Partials 1290 722 -568 |
alessio
reviewed
Jul 11, 2020
| @@ -52,13 +52,16 @@ func NewFactoryCLI(clientCtx client.Context, flagSet *pflag.FlagSet) Factory { | |||
| gasAdj, _ := flagSet.GetFloat64(flags.FlagGasAdjustment) | |||
| memo, _ := flagSet.GetString(flags.FlagMemo) | |||
|
|
|||
| gasStr, _ := flagSet.GetString(flags.FlagGas) | |||
| gasSetting, _ := flags.ParseGasSetting(gasStr) | |||
There was a problem hiding this comment.
Suggested change
| gasSetting, _ := flags.ParseGasSetting(gasStr) | |
| gasSetting, err := flags.ParseGasSetting(gasStr) | |
| if err != nil { | |
| panic(err) | |
| } |
This is because ParseGasSetting must never fail there, but if it does it must panic
There was a problem hiding this comment.
Ideally, we return an error here.
alessio
approved these changes
Jul 11, 2020
fedekunze
approved these changes
Jul 11, 2020
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Use new APIs * fix usage * fix usage of gas flag * tests: TestParseGasSetting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
flags.AddTxFlagsToCmdandflags.AddQueryFlagsToCmdin favor of poorly designed(Get|Post)Commands.closes: #6545
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes