Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/auth: gRPC query service #6565

Merged
merged 10 commits into from
Jul 8, 2020
Merged

Conversation

akhilkumarpilli
Copy link
Contributor

Description

ref: #5921


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@akhilkumarpilli akhilkumarpilli changed the title Add grpc queries in x/auth x/auth: gRPC query service Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #6565 into master will increase coverage by 0.00%.
The diff coverage is 63.63%.

@@           Coverage Diff           @@
##           master    #6565   +/-   ##
=======================================
  Coverage   57.73%   57.73%           
=======================================
  Files         497      498    +1     
  Lines       29767    29796   +29     
=======================================
+ Hits        17186    17203   +17     
- Misses      11343    11350    +7     
- Partials     1238     1243    +5     

@aaronc aaronc mentioned this pull request Jul 1, 2020
43 tasks
@clevinson clevinson added this to the v0.40 [Stargate] milestone Jul 2, 2020
x/auth/keeper/grpc_query.go Show resolved Hide resolved
x/auth/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
@anilcse anilcse marked this pull request as ready for review July 4, 2020 20:03
@anilcse anilcse marked this pull request as draft July 5, 2020 07:51
x/auth/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/auth/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
@sahith-narahari sahith-narahari marked this pull request as ready for review July 7, 2020 03:24
@sahith-narahari sahith-narahari requested a review from fedekunze July 7, 2020 03:25
anilcse
anilcse previously requested changes Jul 7, 2020
x/auth/types/querier.go Outdated Show resolved Hide resolved
@fedekunze fedekunze requested a review from anilcse July 7, 2020 07:53
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 7, 2020
@fedekunze
Copy link
Collaborator

@akhilkumarpilli can you pull master again 🙏

@tac0turtle
Copy link
Member

could vitwit enable modifcation on prs made to this repo. that way the bot can take over and merge this. Otherwise we are stuck in the infinite loop of "please merge master".

@akhilkumarpilli
Copy link
Contributor Author

could vitwit enable modifcation on prs made to this repo. that way the bot can take over and merge this. Otherwise we are stuck in the infinite loop of "please merge master".

we might not be able to do that for this PR as it was from a org repo : https://github.uint.cloudmunity/t/how-can-we-enable-allow-edits-from-maintainers-by-default/2847/8

we will use user repos from next time.

@alessio
Copy link
Contributor

alessio commented Jul 8, 2020

some jobs got stuck - I re-started them

@tac0turtle tac0turtle merged commit 4536ca2 into cosmos:master Jul 8, 2020
@sahith-narahari sahith-narahari deleted the akhil/5921-auth-grpc branch July 8, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants