Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate validate-signatures cmd to SignatureV2 #6470

Closed
wants to merge 10 commits into from

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 18, 2020

ref: #6213

This migrates the x/auth validate-signatures command to use SignatureV2.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #6470 into master will decrease coverage by 3.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6470      +/-   ##
==========================================
- Coverage   57.53%   53.98%   -3.55%     
==========================================
  Files         501      335     -166     
  Lines       30023    18817   -11206     
==========================================
- Hits        17274    10159    -7115     
+ Misses      11504     7983    -3521     
+ Partials     1245      675     -570     

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 4, 2020
@aaronc aaronc removed the stale label Jul 6, 2020
@aaronc
Copy link
Member Author

aaronc commented Jul 6, 2020

bump

@aaronc aaronc mentioned this pull request Jul 7, 2020
27 tasks
@aaronc aaronc changed the title Aaronc/6213 x auth validate sigs Migrate validate-signatures command to SignatureV2 Jul 9, 2020
@aaronc aaronc changed the title Migrate validate-signatures command to SignatureV2 Migrate validate-signatures cmd to SignatureV2 Jul 9, 2020
@aaronc aaronc added the C:x/auth label Jul 9, 2020
@aaronc
Copy link
Member Author

aaronc commented Jul 9, 2020

Should I mark this R4R @sahith-narahari or wait for #6573 ?

@sahith-narahari
Copy link
Contributor

Should I mark this R4R @sahith-narahari or wait for #6573 ?

I would wait for 6573, and add any necessary tests as this is a small PR

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though I agree with @sahith-narahari's remark to use VerifySignature

@aaronc
Copy link
Member Author

aaronc commented Jul 16, 2020

lgtm, though I agree with @sahith-narahari's remark to use VerifySignature

if it works go for it!

@sahith-narahari
Copy link
Contributor

Closing this as it's being tackled in #6717

@tac0turtle tac0turtle deleted the aaronc/6213-x-auth-validate-sigs branch March 4, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants