-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate validate-signatures cmd to SignatureV2 #6470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6470 +/- ##
==========================================
- Coverage 57.53% 53.98% -3.55%
==========================================
Files 501 335 -166
Lines 30023 18817 -11206
==========================================
- Hits 17274 10159 -7115
+ Misses 11504 7983 -3521
+ Partials 1245 675 -570 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
…ronc/6213-x-auth-validate-sigs
…ronc/6213-x-auth-validate-sigs
Should I mark this R4R @sahith-narahari or wait for #6573 ? |
I would wait for 6573, and add any necessary tests as this is a small PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though I agree with @sahith-narahari's remark to use VerifySignature
if it works go for it! |
Closing this as it's being tackled in #6717 |
ref: #6213
This migrates the
x/auth
validate-signatures
command to useSignatureV2
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer